Skip to content

Duration now shown on top of the thumbnail.#34

Merged
theScrabi merged 6 commits intoTeamNewPipe:masterfrom
darkon5:master
Sep 20, 2015
Merged

Duration now shown on top of the thumbnail.#34
theScrabi merged 6 commits intoTeamNewPipe:masterfrom
darkon5:master

Conversation

@darkon5
Copy link
Copy Markdown
Contributor

@darkon5 darkon5 commented Sep 20, 2015

TODO: Replace "Upload date here" with actual upload time, change colors to taste.

(I leave these to you as I think you will make better changes than I could)

@darkon5
Copy link
Copy Markdown
Contributor Author

darkon5 commented Sep 20, 2015

  • Spanish translation :)

darkon5 and others added 2 commits September 20, 2015 17:46
@darkon5
Copy link
Copy Markdown
Contributor Author

darkon5 commented Sep 20, 2015

I made another version where the title is more thin and the upload date and author have different lines.
This is good for the videos with long author names, this way text won't glitch that often.

-> THIS IS NOT INCLUDED IN THIS PULL REQUEST <-

Should I add these changes too?

screenshot_2015-09-20-18-17-01

theScrabi added a commit that referenced this pull request Sep 20, 2015
@theScrabi
Merge pull request #34 from darkon5/master
b20ae45 
Duration now shown on top of the thumbnail.
@theScrabi theScrabi merged commit b20ae45 into TeamNewPipe:master Sep 20, 2015
@theScrabi
Copy link
Copy Markdown
Member

theScrabi commented Sep 20, 2015

Ah we have a problem. Sometimes the user name is so long, that the layout crashes. For now i put the itemUploadDateView benath the username, but that doesn't look pretty good.
screenshot_2015-09-20-20-58-26

@darkon5
Copy link
Copy Markdown
Contributor Author

darkon5 commented Sep 20, 2015

In my smaller version it does not happen:

screenshot_2015-09-20-21-34-10

I'm going to make the final touches and send it for testing. It shouldn't crash with anything.

@theScrabi
Copy link
Copy Markdown
Member

theScrabi commented Sep 20, 2015

k thanks

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.5% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nelson80s nelson80s mentioned this pull request Dec 5, 2025
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@darkon5 @theScrabi